Charge detection for ion current control

A method for controlling the filling of an ion trap with a predetermined quantity of ions. The method comprises generating an ion current by transmitting ions along an ion path to an ion trap, such that ions are accumulated in the ion trap over a transmission time period, wherein the magnitude of the ion current varies in time. The method further comprises detecting at an ion detector at least some ions from the source of ions during a plurality of distinct sampling time intervals interspersed within the transmission time period, and setting the duration of the transmission time period based on the detection of ions at the ion detector. The time difference between the start of a sampling time interval and the start of an immediately subsequent sampling time interval is less than a timescale for variation of the magnitude of the ion current. A controller for controlling the filling of an ion trap with a predetermined quantity of ions and a mass spectrometer comprising the controller is also described.